Only show Nebula tab if already on waitlist, automatically join waitlist on Nebula page visit #5419
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @MananTank and the rest of your teammates on |
MananTank
changed the title
MananTank
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5419 +/- ##
=======================================
Coverage 45.52% 45.52%
=======================================
Files 1070 1070
Lines 55665 55665
Branches 4030 4030
=======================================
Hits 25341 25341
Misses 29637 29637
Partials 687 687
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
Merge activity
|
…ist on Nebula page visit (#5419) ## Problem solved Short description of the bug fixed or feature added <!-- start pr-codex --> --- ## PR-Codex overview This PR introduces a new `ShareButton` component and refactors the handling of the Nebula waitlist across various pages, enhancing user experience with waitlist functionalities and error handling. ### Detailed summary - Added `ShareButton` component for sharing waitlist links. - Refactored `TeamLayout` to conditionally render the `Nebula` path based on waitlist status. - Updated `NebulaWaitListPage` to handle team fetching and waitlist joining. - Replaced `JoinNebulaWaitlistPage` with `NebulaWaitListPage`. - Simplified storybook stories for waitlist pages. - Improved error handling for waitlist status fetching. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
MananTank
force-pushed
the
11-14-update_nebula_waitlist_page
branch
from
8f93d2e to
5de5c44
Compare
vercel
bot
temporarily deployed
to
Production – thirdweb_playground
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on refactoring the
Nebulawaitlist functionality by introducing a newShareButtoncomponent, improving theNebulaWaitListPage, and cleaning up related code. It enhances user experience by allowing sharing links and handling waitlist statuses more efficiently.Detailed summary
nebula-waitlist-page.client.tsx.share-button.client.tsxwith aShareButtoncomponent.layout.tsxto check if users are on the Nebula waitlist.page.tsxto useNebulaWaitListPageinstead ofJoinNebulaWaitlistPage.NebulaWaitListPagewith error handling for team retrieval.NebulaWaitListPageUIand removed unnecessary components.